Skip to content

Conversation

@kov072299
Copy link
Contributor

  • currently, FerretCOT's party is int type.
  • code in write_pre_data128_to_file writes it as int64_t width.
  • code in read_pre_data128_from_file reads int64_t into an int as well.

if sizeof(int64_t) != sizeof(int), stack clobbering in read, and out-of-bounds access in write.

proposed code is temporary fix, maintainers should replace with preferred fix.

@kov072299
Copy link
Contributor Author

looks like this is partial duplicate of #92

@kov072299
Copy link
Contributor Author

this issue is also explained in #89

@wangxiao1254
Copy link
Member

I slightly modified the fix by enforcing that we always write 8 bytes to an 8-byte structure. I will merge it in a few days, in case anyone finds something wrong :)

@wangxiao1254 wangxiao1254 merged commit c7f7742 into emp-toolkit:master Jul 31, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants