Skip to content

refactor(x-bus): move to x-components#1798

Merged
davidglezz merged 4 commits intomainfrom
merge-x-bus
Jul 9, 2025
Merged

refactor(x-bus): move to x-components#1798
davidglezz merged 4 commits intomainfrom
merge-x-bus

Conversation

@davidglezz
Copy link
Contributor

@davidglezz davidglezz commented Jun 4, 2025

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

Move x-bus and x-priority-queue within x-components:

  • x-priority-queue is only used by x-bus
  • x-bus is always used with x-components
  • Each file is ~100 lines of code (fits more with a utility file)
  • Both packages requires setup and maintenance of tools (Jest, typescript, eslint, build, package.json scripts, ...)
    • Changelogs only have tool maintenance, no source changes.
  • Both was designed for x-components
  • NPM stats: No one is using this packages

This means that it does not need to be a standalone package.

Used by:

Migration:

  • Remove "@empathyco/x-bus" dep and update imports:
-import { ... } from '@empathyco/x-bus'
+import { ... } from '@empathyco/x-components/x-bus'

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@davidglezz davidglezz force-pushed the merge-x-bus branch 2 times, most recently from 476efc1 to d7e0ef6 Compare June 16, 2025 16:04
@davidglezz davidglezz marked this pull request as ready for review June 16, 2025 16:06
@davidglezz davidglezz requested a review from a team as a code owner June 16, 2025 16:06
Signed-off-by: davidglezz <davidg@empathy.co>
Signed-off-by: davidglezz <davidg@empathy.co>
I don't think it's the best solution, but it's what I've achieved without spending too much time. I'd like to get those links back.

Signed-off-by: davidglezz <davidg@empathy.co>
Copy link
Contributor

@lauramargar lauramargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidglezz davidglezz assigned davidglezz and victorcg88 and unassigned davidglezz Jul 9, 2025
@davidglezz davidglezz merged commit b185436 into main Jul 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants