Skip to content

fix(result-price): make futureValue optional#1827

Draft
davidglezz wants to merge 2 commits intomainfrom
price-futureValue-optional
Draft

fix(result-price): make futureValue optional#1827
davidglezz wants to merge 2 commits intomainfrom
price-futureValue-optional

Conversation

@davidglezz
Copy link
Contributor

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

"Removing" (making it optional / not mandatory) the not generic price value.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Signed-off-by: davidglezz <davidg@empathy.co>
lauramargar
lauramargar previously approved these changes Aug 6, 2025
Signed-off-by: davidglezz <davidg@empathy.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants