Skip to content

Conversation

@knappe
Copy link
Member

@knappe knappe commented Nov 1, 2016

No description provided.

@knappe knappe force-pushed the Add-Queue-Purging-Config-Option branch from f9292bc to 62bf3d9 Compare November 2, 2016 15:57
@randy-girard randy-girard force-pushed the Add-Queue-Purging-Config-Option branch from 3b825c6 to 6f5fc81 Compare June 13, 2017 14:44
@randy-girard
Copy link
Contributor

@knappe Updated the spec for this

Copy link
Member Author

@knappe knappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit and what I think is now an unnecessary method. Because I'm the author, I can't request these changes.

:type => "dummy.spec"
}
}))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

class SpecConsumer
include Emque::Consuming.consumer

def test(message)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this method now.

@knappe
Copy link
Member Author

knappe commented Jun 13, 2017

@randy-girard Awesome, thanks for pushing this along! 🎉

@randy-girard
Copy link
Contributor

@knappe Addressed your nits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants