Guess endianness of "erased" DWARF info #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngheloAlf
approved these changes
Jun 6, 2025
AngheloAlf
left a comment
AngheloAlf
left a comment
There was a problem hiding this comment.
I confirm this indeed fixed the issue. Thanks a lot!
Owner
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GC OOT emulator, "erased" DWARF data is little-endian despite the ELF being big-endian. In Dr Mario, the "erased" data is apparently still big-endian (different linker version maybe?). So, now
--include-erasedwill try to guess which endianness to use for erased DWARF data.Fixes #85