Skip to content

Conversation

@coweringg
Copy link

@coweringg coweringg commented Nov 17, 2025

The story follows the awakening of Sir Aldren, an ancient knight summoned from oblivion. It is Lyra, a mage weakened by the influence of the Void Lord, who brings him back into the world and pleads for his help.
The Void Lord has cast a curse that limits the powers of all mages and threatens to plunge the land into darkness.

Lyra reveals that the only hope to stop him is Elyndra, a powerful mage whose spirit has been sealed by the Void Lord himself. Only she possesses the ability to imprison his soul forever.

With this truth, Sir Aldren accepts the purpose for which he was awakened: to confront the Void Lord, free Elyndra, and save the world from the fate looming over it.

This story contains:

  • Intro
  • Minigame 1
  • Minigame 2
  • Outro

Screenshots:

  • Intro
image
  • Minigame 1
image
  • Minigame 2
image
  • Outro
image

@coweringg coweringg requested a review from a team as a code owner November 17, 2025 22:14
[node name="PlayerSprite" type="AnimatedSprite2D" parent="."]
unique_name_in_owner = true
position = Vector2(0, -17)
scale = Vector2(0.18, 0.18)
Copy link
Collaborator

@manuq manuq Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sign that your assets for the player are much larger than what they should!

This leads to tiny StoryWeaver if you play one of the lore quests, so unfortunately we can't allow it. I can see that your assets come from an asset pack that has very high resolution. I'm afraid that you'll have to reduce the player assets in a graphics application like Gimp / Photoshop / (Libre)Aseprite, etc if you really want to use them. But before, please post what is this asset pack coming from and check which license does it have.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thank you for your feedback. The assets we used come from an asset pack on CraftPix: “2D Fantasy Knight Free Sprite Sheets.” We have checked the license, and it is allowed for use in projects. Here is the link to the license/details:
https://craftpix.net/freebies/2d-fantasy-knight-free-sprite-sheets/

Thanks again!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you click the "license details" section you will find this license https://craftpix.net/file-licenses/ which has this section (emphasis mine):

1.2 FORBIDDEN
1.2.1 You can NOT resell the source files (PNG, JPG, EPS, Adobe Illustrator, etc.) or slightly modified version of the art. You can not redistribute the art or modified version of the art in a manner that would make some or all of the art files useable to another end user via the app. For example, an app that uses the art as part of the game is fine. An app that allows the user to save or export a modified version of the artwork itself is not fine.

Including these assets in this Git repository violates this term, so these assets cannot be used in Threadbare.

https://github.com/endlessm/threadbare/blob/main/docs/LICENSING.md#asset-licensing discusses this problem.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this was maked as resolved, I see the license considerations stand as before.

@manuq manuq added the StoryQuest New StoryQuests or updates to existing ones label Nov 18, 2025
@coweringg coweringg requested a review from a team as a code owner November 18, 2025 23:39
Copy link
Collaborator

@manuq manuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check with your mentor the very first condition we have for the Story Quest submission:

the PR must be strictly confined to creating and modifying files only within the directory structure that belongs to the StoryQuest. PRs that extend beyond this will be rejected.

Please improve the submission title and description according to this guide

In particular:

  • The Title field should briefly mention what is included in the StoryQuest, and is ideally written in English.
  • The Description should include a brief outline of the work included in the PR. As the story quest content is added to the game via the PRs, this should include what concepts/stories it is built around and what are the main gameplay elements. It is OK to submit this in Spanish. Attribution sections titled as Assets, Engineering, Game Design, and Production & Management. These should reference GitHub usernames of the contributors.

Check how this other team is doing it: #1561

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

Play this branch at https://play.threadbare.game/branches/Anima-EndlessPre-Piloto/despertar-caballero.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@manuq
Copy link
Collaborator

manuq commented Nov 25, 2025

Feel free to continue this in your fork! I'll be closing the pull request for now. If you really want this in the main game, please replace the assets with license issues and reopen this PR. Good luck with your game!

@manuq manuq closed this Nov 25, 2025
@manuq
Copy link
Collaborator

manuq commented Dec 2, 2025

@coweringg I am reopening this since we decided to keep all StoryQuests PRs open for 3 weeks. Upon that time, if we don't hear back from you, we'll be closing them. If you can, please apply our suggestions so we can merge the PR. Thanks!

@manuq manuq reopened this Dec 2, 2025
@manuq manuq changed the title Despertar caballero Add Despertar caballero StoryQuest Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

StoryQuest New StoryQuests or updates to existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants