Conversation
leotm
commented
Apr 9, 2025
Comment on lines
+11
to
+12
| The module name `ses/hermes` can now be required to call `lockdown` and | ||
| `repairIntrinsics` only, `Compartment` is not yet available. |
Contributor
Author
There was a problem hiding this comment.
also will be available at https://npmfs.com/download/ses/1.13.0/dist/ses-hermes.cjs
erights
approved these changes
Apr 9, 2025
Contributor
erights
left a comment
erights
left a comment
There was a problem hiding this comment.
LGTM modulo missing single quotes. Thanks!
packages/ses/NEWS.md
Outdated
| - The `evalTaming:` option `safe-eval` now can only throw error `SES_DIRECT_EVAL`. | ||
| - The [evalTaming](https://github.com/endojs/endo/blob/master/packages/ses/docs/lockdown.md#evaltaming-options) | ||
| option `safe-eval` now can only throw error `SES_DIRECT_EVAL`. | ||
| This allows SES to initialize with `'unsafe-eval'` or `no-eval` on hosts with no |
Contributor
There was a problem hiding this comment.
Still missing single quotes around no-eval.
Suggested change
| This allows SES to initialize with `'unsafe-eval'` or `no-eval` on hosts with no | |
| This allows SES to initialize with `'unsafe-eval'` or `'no-eval'` on hosts with no |
Contributor
Author
There was a problem hiding this comment.
😅 updated and potentially autofixable with a markdownlint custom rule, noted in
leotm
force-pushed
the
doc-evalTaming-news
branch
from
1f36581 to
eb3ee92
Compare
leotm
force-pushed
the
doc-evalTaming-news
branch
from
eb3ee92 to
ba2aa46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to: #2723
Add news for evalTaming