feat: Get token auth link as param#94
Open
Melvin-Abraham wants to merge 3 commits intoendoplasmic:mainfrom
Open
feat: Get token auth link as param#94Melvin-Abraham wants to merge 3 commits intoendoplasmic:mainfrom
Melvin-Abraham wants to merge 3 commits intoendoplasmic:mainfrom
Conversation
- google-auth-library - grpc - mkdirp - open - protobufjs - speaker
Addresses latest API change for `mkdirp` in the `saveToken` function
Passing Auth URL to the custom token input handler function gives the front-end a way to handle unexpected issues when opening the Auth URL in browser.
f3c8f2a to
ba57c3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows Auth URL be passed to the custom token input handler function (
config.tokenInput()) as parameter to provide the front-end a way to handle unexpected issues when opening the Auth URL in browser.