feat(admin-trades): Implementing API and UI #3049
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
alexworker23
left a comment
alexworker23
left a comment
There was a problem hiding this comment.
In general: the implementation of the UI applies to guidelines ✅
| const formatTrades: TFormatTrades = ({ trades, allDevices }) => { | ||
| const formattedTrades: FormattedTrade[] = []; | ||
|
|
||
| trades?.forEach((trade) => { |
Contributor
There was a problem hiding this comment.
const formattedTrades: FormattedTrade[] = trades.map will better fit here
| date: t('admin.trades.date'), | ||
| buyer: t('admin.trades.buyer'), | ||
| seller: t('admin.trades.seller'), | ||
| energy: 'Energy', |
Contributor
There was a problem hiding this comment.
please don't forget to localize this
packages/ui/libs/user/view/src/pages/AdminTradesPage/AdminTradesPage.effects.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a work in progress.
Related to:
OV-1262
OV-1261
API:
UI:
I would like to get feedback about;