✨ Scene Objects Refactor #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an invalid access occurs
…tring&) API instead of calling it create(const string&)
…e variable name changes in level_scene.cpp
…jects through uscene_object and the entity API from the scene class
…r world and application code
…into scene_and_game_objects_refactor
SpinnerX
changed the title
…on of the std::exception as its base class
…hat will be fixed when adding in the level streamer
SpinnerX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156
This PR introduces fundamental changes to TheAtlasEngine, specifically with how game objects are represented. Ensuring safer and idiomatic ways to ensure game object are present in
std::optionalbefore performing an operation with the game object.Changelogs
atlas::scene_object->atlas::game_object.atlas::game_object_optionalwhich is tostd::optional<game_object>.atlas::scene_objectvia inheriting fromflecs::entity.atlas::game_object.atlas::scene_object.atlas::scene_scope->atlas::scene.atlas::world_scope->atlas::world.atlas::ui::draw_input_textto correctly rename the selected entities.