[mob][photos] Add priority debouncer for recent local photos #8660
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1742f7cc8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| final sevenDaysAgo = DateTime.now() | ||
| .subtract(const Duration(days: 7)) | ||
| .microsecondsSinceEpoch; | ||
| hasRecentNewLocalDiscovery = allFiles.any( | ||
| (file) => (file.creationTime ?? 0) > sevenDaysAgo, |
There was a problem hiding this comment.
The priority flag is computed using allFiles.any(...), but allFiles includes existing files from the sync window, not just the newly discovered ones. As a result, if the library already contains any recent photo and you import only old photos, hasRecentNewLocalDiscovery becomes true and triggers the 200ms priority refresh even though the new items are not recent. This defeats the intent (“newly discovered” within 7 days) and can cause unnecessary refresh churn on bulk imports; consider checking only the newly inserted list (e.g., the files list after filtering) or explicitly filtering allFiles to the newly discovered IDs.
Useful? React with 👍 / 👎.
Add a fast-path (200ms) debouncer for newly discovered local files created within the last 7 days. This reduces the delay when recently taken photos appear in the home gallery from 2-7 seconds to < 500ms. The standard debouncing (2s debounce, 5s execution interval) remains unchanged for all other sync events to maintain UI stability. Changes: - Add hasRecentNewLocalDiscovery flag to LocalPhotosUpdatedEvent - Compute 7-day recency check in LocalSyncService - Add priorityReloadDebounceTime parameter to Gallery widget - Route priority events to fast-path debouncer in home gallery
neeraj-pilot
force-pushed
the
neeraj/priority-debouncer-recent-photos
branch
from
a1742f7 to
6c1ea26
Compare
2 participants
Summary
Test plan