Open
Conversation
vpaturet
force-pushed
the
fix_npe_in_line_info_collector
branch
2 times, most recently
from
2dbc857 to
2cb5dac
Compare
vpaturet
force-pushed
the
fix_npe_in_line_info_collector
branch
from
2cb5dac to
0e9ea37
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LineInfo collector fails when parsing a FlexibleLine if its type is not "fixed". This PR fixes this.
The original implementation attempted to exclude non-fixed flexible lines, but there does not seem to be a reason why the LineInfoCollector could not collect data from all types of lines.