Refactor LineInfoCollector to use repository abstraction

[vpaturet]

Overview

This PR introduces a repository pattern to encapsulate the Redisson API usage in LineInfoCollector, improving separation of concerns and testability.

Changes

New Files

• LineInfoMemStoreRepository.java - Interface defining the contract for line info storage
• RedisLineInfoMemStoreRepository.java - Redis-based implementation with distributed locking

Modified Files

• LineInfoCollector.java

  • Removed direct RedissonClient dependency
  • Removed lineInfoCache direct access
  • Removed addLineName() method (logic moved to repository)
  • Added null safety check for lineInfo before storing
  • Lines changed: -46 lines of infrastructure code, +11 lines of clean business logic

• NetexDataCollectorConfig.java

  • Added repository bean configuration
  • Updated collector bean to use repository

Benefits

• ✅ Better separation of concerns: Collector focuses on data extraction, repository handles storage
• ✅ Redisson API fully encapsulated: All distributed locking logic behind clean interface
• ✅ Easier to test: Can mock repository without Redis infrastructure
• ✅ Consistent architecture: Follows existing TemporaryFileRepository pattern
• ✅ Code reduction: Reduced LineInfoCollector from 82 to 58 lines (-29%)

Testing

✅ All existing tests pass without modification
✅ No test changes required
✅ All integration tests with Redis passed
✅ No performance regression detected

Future Work

This refactoring establishes a pattern that can be applied to other collectors:

• ScheduledStopPointIdCollector
• ServiceJourneyInterchangeInfoCollector
• ServiceJourneyStopsCollector
• ServiceJourneyActiveDatesCollector

Migration Notes

• No breaking changes to external APIs
• No configuration changes required
• Backward compatible with existing deployments

[sonarqubecloud]

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE