Fixed halflife retrieval, added rate constant retrieval #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorsbach
reviewed
May 20, 2025
| """ | ||
| if value not in self.allowed_types: | ||
| raise ValueError(f"The value {value} does not belong to the set of allowed values {self.allowed_types}") | ||
| # if value not in self.allowed_types: |
Contributor
There was a problem hiding this comment.
Whats the reason for getting rid of this check?
Contributor
Author
There was a problem hiding this comment.
it is too restrictive for the data in soil and sludge. I commented out most stuff that is too restrictive, but would make sense to have at some point.
| name = "minormajor" | ||
| mandatories = ['radiomin'] | ||
| allowed_values = ["minor", "major"] | ||
| #allowed_values = ["minor", "major", "neither"] |
Contributor
There was a problem hiding this comment.
"neither" added but commented out?
Contributor
Author
There was a problem hiding this comment.
also here it is supposed to be the commented version but it is too restrictive
| """ | ||
| if value.lower() not in self.allowed_values: | ||
| raise ValueError(f"{value} is not one the allowed_values {self.allowed_values}") | ||
| #if value.lower() not in self.allowed_values: |
Contributor
There was a problem hiding this comment.
Same as above, is it now optional?
| """ | ||
| parts = data_string.split(';') | ||
| dt50 = parts[3] | ||
| if parts[0] == 'SFO': |
| """ | ||
| name = "samplingdepth" | ||
| mandatories = ["samplingDepthMin"] | ||
| mandatories = [] # "samplingDepthMin" |
Contributor
Author
There was a problem hiding this comment.
also too restricitve since some additional information doesnt contain any minimal value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed also some addinfo bugs since most of the time converting the values to float was too restrictive when trying to retrieve the data from the existing datasets in envipath