Fixed incorrect representation of array index parsing#33
Open
Conversation
Member
|
I am missing precedence rules for unary operators, I think. Assuming left to right as a base rule. This would mean that !array[0] would fail for example |
Member
Author
|
I’d have to double-check, but I’m quite sure that, due an implementation quirk of the pratt parser we have, it actually matches any prefixed unary expressions first, and then it does binary & postfix unary. Which should result in the correct binding, in your example. But please double-check by finding out 😇 Not sure how to encode that in the grammar, though. Aren’t they included in the association & precedence tables? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect grammar rule that array indices can only follow array literals. Instead, it is modelled as a special kind of unary operator which follows its operand.
Fixes #29