Skip to content

Add 5cs evaluation instrument#11

Merged
firste merged 16 commits intoepic-open-source:mainfrom
guzmanben16:main
Aug 4, 2025
Merged

Add 5cs evaluation instrument#11
firste merged 16 commits intoepic-open-source:mainfrom
guzmanben16:main

Conversation

@guzmanben16
Copy link
Contributor

@guzmanben16 guzmanben16 commented Jul 18, 2025

Overview

Closes #xxx

Description of changes

Author Checklist

  • Linting passes; run early with pre-commit hook.
  • Tests added for new code and issue being fixed.
  • Added type annotations and full numpy-style docstrings for new methods.
  • Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2025

CLA assistant check
All committers have signed the CLA.

@diehlbw
Copy link
Contributor

diehlbw commented Jul 28, 2025

🧹Some bookkeeping stuff:
You'll need to "sign" the CLA agreement, my understanding of legalese (not a lawyer) is that it says you have the rights to contribute the content you are adding.

Also, you'll need to create a new file ("newsfragment") changelog/11.feature.rst which can be a oneliner about adding the 5cs instrument. These will be compiled at points into a single doc (see changelog/README.rst)

@diehlbw diehlbw requested a review from firste July 31, 2025 10:48
diehlbw
diehlbw previously approved these changes Jul 31, 2025
Copy link
Contributor

@diehlbw diehlbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding Elliot to have fresh eyes on the README (and notebook prose)

Copy link
Contributor

@firste firste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One hopefully quick update

firste
firste previously approved these changes Aug 4, 2025
@firste firste self-requested a review August 4, 2025 19:50
@firste firste merged commit 033e330 into epic-open-source:main Aug 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants