Skip to content

Comments

minimal change for backwards compatibility post-otel#175

Open
diehlbw wants to merge 2 commits intoepic-open-source:mainfrom
diehlbw:otel_backwards_compatibility
Open

minimal change for backwards compatibility post-otel#175
diehlbw wants to merge 2 commits intoepic-open-source:mainfrom
diehlbw:otel_backwards_compatibility

Conversation

@diehlbw
Copy link
Collaborator

@diehlbw diehlbw commented Aug 6, 2025

Overview

A seismograph could break if it extends ConfigProvider, since otel setup expects an attribute that isnt initialized.

Description of changes

initialize config attr to None.
skip the otel initialization if None

Will write up issue (#176) for more integrated solution, likely a from_config method that handles the none case internally producing the NoOp manager.

Considered sufficient for a fix

Author Checklist

  • Linting passes; run early with pre-commit hook.
  • Tests added for new code and issue being fixed.
  • Added type annotations and full numpy-style docstrings for new methods.
  • Draft your news fragment in new changelog/ISSUE.TYPE.rst files; see changelog/README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants