Fix array handling, filter repr, imputation logic, and pandas FutureW…#187
Open
MahmoodEtedadi wants to merge 2 commits intoepic-open-source:mainfrom
Open
Fix array handling, filter repr, imputation logic, and pandas FutureW…#187MahmoodEtedadi wants to merge 2 commits intoepic-open-source:mainfrom
MahmoodEtedadi wants to merge 2 commits intoepic-open-source:mainfrom
Conversation
…arning - cohorts.py: support numpy arrays in resolve_col_data with proper index alignment - filter.py: fix FilterRule string repr for non-string values - pandas_helpers.py: fix imputation row counting and merge strategy fallback - _util.py: skip empty concat in add_unseen to resolve pandas FutureWarning
MahmoodEtedadi
requested review from
diehlbw and
gbowlin
and removed request for
gbowlin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix issues in cohorts, filter, pandas helpers and resolve pandas FutureWarning
Description of changes
Author Checklist
.. versionchanged:: NEXT_VERSION_PLACEHOLDERdirective to affected docstrings.changelog/ISSUE.TYPE.rstfiles; see changelog/README.md.