Changes Card-Stack-Layout (chapter 5)#17
Open
dgruntz wants to merge 3 commits intoeppleton:masterfrom
dgruntz:kap-5
Open
Changes Card-Stack-Layout (chapter 5)#17dgruntz wants to merge 3 commits intoeppleton:masterfrom dgruntz:kap-5
dgruntz wants to merge 3 commits intoeppleton:masterfrom
dgruntz:kap-5
Conversation
instead of passing
new StackPane(iconView)
new StackPane(anchorPane)
to the new scene, you could also simply pass the
iconView
anchorPane
to the scene.
Ok, the StackPane would allow to add additional controls, but this is
not needed here.
Adds the invocation of cardStackLayout.setMinHeight(200); to the top card stack otherwise the first row disappears if all cards have been moved to the second row. For symmetry reasons this min height is set on both cardStackLayout instances.
Removes the header which was generated by Eclipse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the invocation of
cardStackLayout.setMinHeight(200);
to the top card stack otherwise the first row disappears if all cards have been moved to the second row (for symmetry reasons this min height is set on both cardStackLayout instances).
Moreover, instead of passing
new StackPane(iconView)
new StackPane(anchorPane)
to the new scene, you could also simply pass the
iconView
anchorPane
to the scene.
Ok, the StackPane would allow to add additional controls, but this is not used here.