Open
Conversation
By invoking updateProgress(max, max); the properties are informed that the task is completed. [this should probably be added to the former projects as well.]
In the original version the RefreshService was declared as a local variable in the constructor and was reclaimed by the GC after creation of the timeline. The call homeTimeline.refresh() declared in the MainApp is no longer needed (was commented out). Without that code the timeline was not initialized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the progress indicator to be finished
By invoking
the properties are informed that the task is completed.
[this should probably be added to the former projects as well.]
Fixes a bug in tweetalot (chap 9.4)
In the original version the
RefreshServicewas declared as a local variable in the constructor and was reclaimed by the GC after creation of the timeline.The call
homeTimeline.refresh()declared in theMainAppis no longer needed (was commented out). Without that code the timeline was not initialized.