Bug fixes in chapter 13#22
Open
dgruntz wants to merge 3 commits intoeppleton:masterfrom
dgruntz:kap-13
Open
Conversation
This commit fixes the treeview expand/collapse arrow bug as described in https://stackoverflow.com/questions/50011276/javafx-treeview-expand-collapse-disclosure-arrow-bug It adds a style file (tree.css) which defines the rotation angle of the arrow for both the normal and the expanded case.
Removes
menuBar.getMenus().add(navigateMenu);
as the menu is also added with the command
menuBar.getMenus().addAll(navigateMenu, historyMenu);
It appeared twice.
When an entry is removed from list historyMenu.getItems() in the loop
for (MenuItem i : historyMenu.getItems()) {
if (i.getId().equals(e.getUrl())) {
historyMenu.getItems().remove(i);
}
}
then a CME is thrown. Iterating over a copy fixes this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the treeview expand/collapse arrow bug
This commit fixes the treeview expand/collapse arrow bug as described in
https://stackoverflow.com/questions/50011276/javafx-treeview-expand-collapse-disclosure-arrow-bug
It adds a style file (
tree.css) which defines the rotation angle of the arrow for both the normal and the expanded case.Removes doubled navigate menu
Removes
as the menu is also added with the command
It appeared twice.
Fixes the CME exception
When an entry is removed from list historyMenu.getItems() in the loop
then a CME is thrown. Iterating over a copy fixes this problem. An alternative would be to leave the loop with a break, but this only works if the menu item
iappears at most once in the list.