Skip to content

[WIP] use other headers, when ETAG is missing #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dduenker wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] use other headers, when ETAG is missing #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccac88c
use LAST-MODIFIED as ETAG, when ETAG is missing
dduenker Apr 7, 2021
2762ec1
collapse else
dduenker Apr 7, 2021
6847010
Merge branch 'master' into master
epwalsh May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use glob::glob;
use log::{debug, error, info, warn};
use rand::distributions::{Distribution, Uniform};
use reqwest::blocking::{Client, ClientBuilder};
use reqwest::header::ETAG;
use reqwest::header::{ETAG, LAST_MODIFIED};
use std::default::Default;
use std::env;
use std::fs::{self, OpenOptions};
Expand Down Expand Up @@ -586,7 +586,16 @@ impl Cache {
debug!("No ETAG for {}", url);
Ok(None)
}
} else if let Some(last_modified) = response.headers().get(LAST_MODIFIED) {
if let Ok(s) = last_modified.to_str() {
debug!("LAST-MODIFIED: {}", s);
Ok(Some(s.into()))
} else {
debug!("No LAST-MODIFIED for {}", url);
Ok(None)
}
} else {
debug!("No LAST-MODIFIED for {}", url);
Ok(None)
}
}
Expand Down