Remove res2df from mypy ignore #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 49 49
Lines 7293 7293
=======================================
Hits 6087 6087
Misses 1206 1206 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
larsevj
force-pushed
the
remove_res2df_ignore
branch
from
da02b68 to
edade29
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes res2df.* from the mypy ignore list, enabling type checking for the res2df library. This change indicates that res2df now provides type hints or type stubs, allowing mypy to perform type checking on code that uses this library.
Key Changes
- Enables mypy type checking for res2df by removing it from the
ignore_missing_importslist in the mypy configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will wait for new res2df release.