This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Support for GitHub commits #31
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30.
Adds a new
Commitclass and aTree:getCommitmethod.Technically, a Git commit owns/references a Git tree rather than vice-versa, but the GitHub API doesn't quite work that way: you can
GET /repos/:owner/:repo/git/trees/:commit_ish, but strangely, commit-ishes don't work with the commits API;GET /repos/:owner/:repo/git/commits/masterfails with a 404. Plus restructuring the Lua API to haveCommitownTreewould probably have broken backwards compatibility in a number of ways, so I just made the minimal number of changes to make this feature work.This could be merged now, but
Tree:getCommitwill require corrections if merged after #27, becauseself.shamay still be set to a commit-ish rather than a SHA beforeTree:getContentsis called.Going to test this out a bit before I mark it ready for review.