Open
Conversation
Author
|
Any comments / reviews / suggestions for this before it can be merged? |
x80486
reviewed
Feb 9, 2022
| del /f .\otp-installer.exe | ||
|
|
||
| # This is a workaround for nanoserver where not possible to set PATH using setx or similar | ||
| ENV PATH="C:\Windows\system32;C:\Windows;C:/Program Files/erl-${OTP_VERSION}/bin" |
There was a problem hiding this comment.
So PowerShell arbitrarily understand back- and forward-slashes? In any case, I would think it better to stick to one "style" to avoid any confusion(s).
Author
There was a problem hiding this comment.
Agreed, good spot, fix coming up
|
@joeapearson I'm just curious -- since your original post, have you learned any more on why the nano server image is not compatible at the moment? We would very much like to get the smaller image size (specifically for RabbitMQ). I'm willing to contribute a PR, but unfortunately I wouldn't even know where to start or if I'd actually be any help with no erlang contribution or low-level Windows dev experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Windows containers (as proposed in #360 ).
Unlike Linux-flavoured containers, Windows insists that a containers base OS and host OS version must match precisely. Therefore I've added both the Windows image name and tag into the tagged Erlang images. In practice, a mismatched host + container OS may work but be prepared for sudden and rather cryptic failures. Microsoft does appear to be actively improving this situation so perhaps this may become a thing of the past eventually.
I've picked a Windows base image version of
10.0.17763.2114because that's the current version of Windows in Azure Kubernetes Service, in anticipation that this will be the correct version for most users at the time of writing. Adding more base images should be simply a case of adding to the actionsmatrix.Things that are missing:
windows/nanoserversupport is not present. Adding support would be a case of figuring out what missing dependencies there are for both the installer and Erlang/OTP itself, and adding them into thenanoserverimage at build time. This is tedious work but the bonus would be a much reduced image size. I suggest leaving this as a separate matter for a future MR.