Skip to content

Conversation

@eschmidt42
Copy link
Owner

This pull request refactors imports and type references throughout the codebase to simplify and standardize the usage of parameters and utility functions. It also moves the bool_to_float utility function to a more appropriate location and updates related tests accordingly. No core logic is changed, but the codebase is now cleaner, with improved maintainability and clarity.

Refactoring and Simplification of Imports and Type References:

  • Replaced all fully-qualified references to parameter types (such as random_tree_models.params.MetricNames) with direct imports and usage throughout estimators.py and split.py, making the code more concise and readable. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Utility Function Relocation:

  • Moved the bool_to_float function from gradientboostedtrees.py to utils.py, and updated all usages and imports accordingly. [1] [2] [3]

Test Updates and Cleanup:

  • Updated test files to import classes and parameters directly, removing unnecessary module-level imports and making type checks more explicit. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Removed the redundant and now unnecessary test_bool_to_float test, as the function is now a generic utility.…unch of other things

@eschmidt42 eschmidt42 merged commit a0746eb into main Aug 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants