Open
Conversation
AeroXuk
force-pushed
the
feature/tailscale
branch
from
8756c86 to
e2f5a6c
Compare
Contributor
|
Tested it, without reading the code itself. It's unfortunate, that it's not possible to validate the validity of the hostname string in a better way. If something incompatible is entered, it just fails without clear feedback. That could trip up non-technical users. |
SimJoSt
reviewed
Feb 21, 2026
| { | ||
| "question": "Hostname", | ||
| "description": "The hostname for Tailscale Node.\nOnly lowercase letters, numbers, and hyphens are allowed.\nSame as `--hostname` flag.", | ||
| "placeholder": "$SERVER_HOST_NAME", |
Contributor
There was a problem hiding this comment.
I'm not the biggest fan of the hostname placeholder $SERVER_HOST_NAME.
It'd prefer something that the user might actually enter, like hexos.
Contributor
|
Are you considering adding more question for the remaining options, like exit node mode? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new installation script for Tailscale, including configuration options and requirements. Update documentation to reflect the addition.
This is based on the Custom Install Script found at https://hub.hexos.com/topic/4267-trial-tailscale-custom-install/.
I've editted and validated the install script against the TrueNAS app schema.
The following changes were made to the version from the forum:
installation_questionsdescriptions.ensure_directories_exists.accept_routestoapp_valueswith the default value from the truenas app schema.