fix(build) Cross platform MD5 hash computation for binary files (ESF-263) #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bin2array.cmake file in the examples directory calculates md5 checksums of binary files using the program
md5sum. The execution of the externalmd5sumcommand will only work on certain systems. CMake has a built-in, cross-platform MD5 function.This method works on any system and is not dependent on external command execution
Related
Testing
I have tested this on Ubuntu and Windows.
Checklist
Before submitting a Pull Request, please ensure the following: