EIM-401 moved checking qemu prerequisities to separate function

[Hahihula]

EIM-401 moved checking qemu prerequisities to separate function and calling it only in case qemu is selected for installation

[gemini-code-assist]

Summary of Changes

Hello @Hahihula, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the system prerequisite checking process, particularly for QEMU. The core change involves isolating QEMU dependency checks into a separate, on-demand function, ensuring these checks only occur when QEMU is part of the installation plan. This enhances performance by avoiding unnecessary checks and improves the user experience with more precise error reporting through new localization strings.

Highlights

• QEMU Prerequisite Refactoring: The logic for checking QEMU prerequisites has been extracted into a dedicated function, check_qemu_prerequisites, and is now only invoked if QEMU is selected for installation.
• Modular Prerequisite Checks: The general prerequisite checking mechanism has been made more modular by separating QEMU-specific dependencies from general system dependencies, improving clarity and efficiency.
• New Localization Strings: Several new localization keys have been added to app.yml to provide clearer user feedback regarding QEMU prerequisite status, including messages for missing dependencies, check errors, and unmet conditions.
• Code Structure Enhancements: The system_dependencies.rs file now includes a new private helper function check_tools_installed to centralize the logic for verifying tool installations, and several structs in idf_tools.rs now derive PartialEq for improved comparison capabilities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully refactors the QEMU prerequisite checking logic into a separate function, improving code modularity. The changes are applied to both the CLI wizard and the GUI. However, I've identified several critical issues, particularly in the GUI implementation, such as typos in translation keys and the use of non-existent keys, which could lead to runtime panics. There are also opportunities to enhance error reporting in the GUI and to adopt more idiomatic Rust patterns. Please review the detailed comments for specific suggestions.