-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Clock Info] Add health category setting #4148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add setting to organize HRM and Steps clockinfos into 'Health' category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a new setting to control whether health-related clock info items (steps, HRM) should be organized into a separate "Health" category. The default behavior keeps these items in the main "Bangle" list (healthCategory: false).
Changes:
- Added a new
healthCategoryboolean setting with default valuefalse - Refactored code to conditionally place health items in either a dedicated "Health" category or the main "Bangle" list
- Updated documentation to describe the new setting and its purpose
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/clock_info/settings.js | Adds UI toggle for the new Health Category setting |
| apps/clock_info/metadata.json | Bumps version from 0.25 to 0.26 |
| apps/clock_info/lib.js | Implements conditional categorization logic for health items |
| apps/clock_info/README.md | Documents the new Health Category setting and updates formatting |
| apps/clock_info/ChangeLog | Records the version 0.26 change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove unnecessary blank line in load function.
|
Thanks! Looks good to me! I just changed the |
Adds a setting for whether or not health clockInfos (steps, hrm) should be moved to a
Healthlist. This is from the discussion at #4092 and is related to PR #4142. The default is false.