Skip to content

Conversation

@RKBoss6
Copy link
Contributor

@RKBoss6 RKBoss6 commented Feb 2, 2026

Adds a setting for whether or not health clockInfos (steps, hrm) should be moved to a Health list. This is from the discussion at #4092 and is related to PR #4142. The default is false.

@RKBoss6 RKBoss6 marked this pull request as ready for review February 2, 2026 21:13
Copilot AI review requested due to automatic review settings February 2, 2026 21:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new setting to control whether health-related clock info items (steps, HRM) should be organized into a separate "Health" category. The default behavior keeps these items in the main "Bangle" list (healthCategory: false).

Changes:

  • Added a new healthCategory boolean setting with default value false
  • Refactored code to conditionally place health items in either a dedicated "Health" category or the main "Bangle" list
  • Updated documentation to describe the new setting and its purpose

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/clock_info/settings.js Adds UI toggle for the new Health Category setting
apps/clock_info/metadata.json Bumps version from 0.25 to 0.26
apps/clock_info/lib.js Implements conditional categorization logic for health items
apps/clock_info/README.md Documents the new Health Category setting and updates formatting
apps/clock_info/ChangeLog Records the version 0.26 change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RKBoss6 and others added 2 commits February 2, 2026 16:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gfwilliams
Copy link
Member

Thanks! Looks good to me!

I just changed the Default: text back to default= in the Readme as you'd left at least one other line in there with default= - better to keep them all in the same style.

@gfwilliams gfwilliams merged commit df29eba into espruino:master Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants