sleeplog: put use of HRM data behind a setting preferHRM
#4156
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is not tested yet. |
bobrippling
reviewed
Feb 6, 2026
| 0.23: Fix important bug with HRM data being undefined when compared - broken apps should work properly now | ||
| 0.24: Change day title to be easier to read, capitalization, and improved documentation/tuning guide in README. | ||
| 0.25: Put HRM mode behind the setting `Prefer HRM` which defaults to `false`. | ||
| Please turn it on if you want the recent HRM behavior. The new default |
Collaborator
There was a problem hiding this comment.
Maybe:
Suggested change
| Please turn it on if you want the recent HRM behavior. The new default | |
| Please turn it on if you want the original HRM behavior. The new default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed around: https://github.com/orgs/espruino/discussions/7801#discussioncomment-15711051
Also previously here: #4023 (comment)