lcdclock/lcdclockplus: fix/extend regexp for clockinfo menus #4161
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobrippling
reviewed
Feb 9, 2026
| if (info.img) g.drawImage(info.img, options.x+2, options.y+2); | ||
| var title = clockInfoItems[options.menuA].name; | ||
| var text = info.text.toString().toUpperCase().replace(/[^A-Z0-9-.]/g, ""); | ||
| var text = info.text.toString().toUpperCase().replace(/[^A-Z0-9.:\-]/g, ""); |
Collaborator
There was a problem hiding this comment.
Would you mind checking this without the espace character? It won't have any effect since - isn't a special character:
/[-]/ .test("hi - there") // true
/[\-]/.test("hi - there") // true
/[-]/ .test("hi there") // false
/[\-]/.test("hi there") // false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing e.g. weather info on the watch, the display/layout for temperature is broken/misplaced/invisible on lcdclock and lcdclockplus inside the clockinfo menus.
This PR adds an escape character to the hyphen, which broke the weather clockinfo display. It also adds the colon to the regexp to allow this character in the clockinfo.
https://freubert.github.io/BangleApps/