Skip to content

Conversation

@subhampro
Copy link
Contributor

@subhampro subhampro commented Oct 12, 2025

Description

This PR moves custom props (handcuffs) from the esx_policejob resource to a new centralized esx_custom_props resource. This creates a dedicated resource for managing all custom props across ESX resources.


Motivation

  • Centralizes custom prop management to avoid conflicts between resources
  • Provides a single location for all custom props used across ESX resources
  • Improves modularity and maintainability of the codebase
  • Prevents duplicate prop files across multiple resources

Implementation Details

  • Created new esx_custom_props resource with proper structure
  • Moved handcuffs.ydr and handcuffs.ytyp from esx_policejob/stream/ to esx_custom_props/stream/
  • Updated esx_policejob fxmanifest to depend on esx_custom_props
  • Removed custom prop entries from esx_policejob manifest
  • Added comprehensive documentation for future prop additions

Usage Example

-- In any resource that needs custom props, add dependency:
dependencies {
    'esx_custom_props'
}

-- Props are automatically loaded and available in-game
-- No additional code changes needed for existing functionality

PR Checklist

  • [✅] My commit messages and PR title follow the Conventional Commits standard.
  • [✅] My changes have been tested locally and function as expected.
  • [✅] My PR does not introduce any breaking changes.
  • [✅] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@N0tNvll
Copy link
Contributor

N0tNvll commented Oct 14, 2025

I already tested and all good

@N0tNvll N0tNvll requested review from FBFezz and N0tNvll October 14, 2025 16:10
@N0tNvll N0tNvll added the enhancement New feature or request label Oct 14, 2025
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants