Skip to content
This repository was archived by the owner on Oct 18, 2022. It is now read-only.

Replace error with warnings#16

Open
alphastorm wants to merge 1 commit intoethereum-optimism:feat/0.6/silence-errorsfrom
alphastorm:feat/0.6/silence-errors
Open

Replace error with warnings#16
alphastorm wants to merge 1 commit intoethereum-optimism:feat/0.6/silence-errorsfrom
alphastorm:feat/0.6/silence-errors

Conversation

@alphastorm
Copy link

@alphastorm alphastorm commented Feb 13, 2021

Description

This is a backport of a fix from the feat/0.7/silence-errors branch to enable the __DANGEROUS_OVM_IGNORE_ERRORS__ flag that was added in ethereum-optimism/plugins#4 to work with solidity 0.6.

8288d0e

Checklist

  • Code compiles correctly
  • All tests are passing
  • New tests have been created which fail without the change (if possible)
  • README / documentation was extended, if necessary
  • Changelog entry (if change is visible to the user)
  • Used meaningful commit messages

This is a backport of a fix from the `feat/0.7/silence-errors` branch to
enable the `__DANGEROUS_OVM_IGNORE_ERRORS__` flag to work with solidity 0.6.

ethereum-optimism@8288d0e
@ben-chain
Copy link
Contributor

This is awesome, thanks!!! Would you be able to make this PR against feat/0.6/silence-errors instead of develop-0.6? I think we wanna keep errors on for the default branches. :)

@alphastorm alphastorm changed the base branch from develop-0.6 to feat/0.6/silence-errors February 15, 2021 19:27
@alphastorm
Copy link
Author

This is awesome, thanks!!! Would you be able to make this PR against feat/0.6/silence-errors instead of develop-0.6? I think we wanna keep errors on for the default branches. :)

Updated!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants