Skip to content

Conversation

@manuwarfare
Copy link

On Debian, the expected path is Cryptodome. I made a small adjustment so that the scripts use both Crypto and Cryptodome paths.

Please consider carefully evaluating this change and accepting this PR if you are interested. If there is anything wrong with it, let me know.

Regards,

@kclowes
Copy link
Contributor

kclowes commented Jul 9, 2025

It looks like we'd need to install pycryptodomex in order for the Cryptodome namespace to work. Have you found that to be the case? If so, let's add it to setup.py.

@manuwarfare
Copy link
Author

It looks like we'd need to install pycryptodomex in order for the Cryptodome namespace to work. Have you found that to be the case? If so, let's add it to setup.py.

Thanks for your reply... The problem is that @sorenstoutner and I are packaging eth-hash for Debian, and pycryptodomex isn't in Debian. Only pycryptodome, which provides the Cryptodome namespace, is available.

This patch allows the use of both Crypto and Cryptodome namespaces. This way, we were able to package eth-hash without any issues. However, it's necessary for (you) the upstream to thoroughly review the changes.

@sorenstoutner
Copy link

It looks like we'd need to install pycryptodomex in order for the Cryptodome namespace to work. Have you found that to be the case? If so, let's add it to setup.py.

This makes sense so that users who get the package through the traditional means can choose to use pycryptodomex if they like. I think we should be able to accomplish this by adding the following lines to setup.py.

    "pycryptodomex": [
        "pycryptodomex>=3.6.6,<4",
    ],

@manuwarfare
Copy link
Author

It looks like we'd need to install pycryptodomex in order for the Cryptodome namespace to work. Have you found that to be the case? If so, let's add it to setup.py.

Soren and I have already updated this PR to include the necessary changes in setup.py to support pycryptodomex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants