-
Notifications
You must be signed in to change notification settings - Fork 463
add engine_getBlobsV3 method #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I think appending it to Osaka is fine if this method is about to be rolled out before Amsterdam. We had such precedent before with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a doctoc run. I tried pushing it to your branch but didn't have perms. Other than that, LGTM!
# install doctoc first
$ doctoc ./src/engine/osaka.md
Implementation tracker
|
de1f396 to
400a78c
Compare
CL clients can make use of partial responses to exchange just the missing cells. This method allows the CL to request partial responses from the EL. Co-Authored-By: raulk <raul.kripalani@gmail.com>
400a78c to
4fc0822
Compare
|
CI failing due to #708 |
mkalinin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! It would be great to see a few approvals from devs before merging it
CL clients can make use of partial responses to exchange just the missing cells. This method allows the CL to request partial responses from the EL.
This method is identical to getBlobsV2 but returns null entries if a blob is not available locally.
See https://ethresear.ch/t/gossipsubs-partial-messages-extension-and-cell-level-dissemination/23017 for context on cell level dissemination. See #674 for the prior version of this PR. That PR was closed to avoid adding a new requirement to Fusaka.
The changes here are currently in ./src/engine/osaka.md, but I'm happy to move them to a new file if folks prefer that. Maybe titled osaka-BPO-X.md where X is the BPO number we want these changes to be available in?
Implementing this method is not mandatory as CL clients can fallback to getBlobsV2. However for cell level dissemination to be useful, the EL needs to provide this method.