core/vm: refactor call gas calculation to avoid state lookups when not necessary #33380
+168
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwasinger
commented
Dec 9, 2025
| // - 63/64ths rule | ||
| gas, err := oldCalculator(evm, contract, stack, mem, memorySize) | ||
| if warmAccess || err != nil { | ||
| return gas, err |
Contributor
Author
There was a problem hiding this comment.
returning old here in the case of an error doesn't have any special meaning. If the dynamic gas calculator returns an error, the returned gas is ignored in the interpreter loop here
jwasinger
force-pushed
the
call-gas-revamp
branch
from
87c95b5 to
bb8a91b
Compare
gballet
requested changes
Dec 19, 2025
Member
gballet
left a comment
gballet
left a comment
There was a problem hiding this comment.
doing this, you are very likely to break a ton of use cases from the verkle/UBT stuff
| } else if !evm.StateDB.Exist(address) { | ||
| gas += params.CallNewAccountGas | ||
| } | ||
| if transfersValue && !evm.chainRules.IsEIP4762 { |
Member
There was a problem hiding this comment.
Don't change the order here, you are guaranteed to break some tests. We can't generate the fixutres because the execution-spec-tests rewrite is still incomplete, so you don't see it... but it's going to break them.
jwasinger
force-pushed
the
call-gas-revamp
branch
2 times, most recently
from
161a6f6 to
675d675
Compare
…enough gas to cover cost component that doesn't depend on state lookups
jwasinger
force-pushed
the
call-gas-revamp
branch
from
82522cb to
bdd7730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EIP-7928 brings state reads into consensus by recording accounts and storage accessed during execution in the block access list. As part of the spec, we need to check that there is enough gas available to cover the cost component which doesn't depend on looking up state. If this component can't be covered by the available gas, we exit immediately.
The portion of the call dynamic cost which doesn't depend on state lookups:
This PR: