event: handle empty subscription list in JoinSubscriptions #33382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
JoinSubscriptionswould block indefinitely when called with zero subscriptions. The select statement had no cases that could complete since no goroutines were spawned to send errors.Changes
JoinSubscriptionsunsubbedchannel closure, allowing proper cleanup without blockingTestMultisubEmptyto verify the fix and prevent regression