ethstats: report newPayload processing time to stats server #33395
+89
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NewPayloadEvent to track engine API newPayload block processing times and report them to ethstats. This enables monitoring of block processing performance on the stats dashboard. - Add NewPayloadEvent type in core/events.go - Add event feed and subscription methods to Ethereum struct - Emit event from catalyst API after successful block insertion - Subscribe and report payload stats in ethstats service
Member
|
@Savid I pushed a commit on top, ptal |
MariusVanDerWijden
requested review from
MariusVanDerWijden,
fjl,
jwasinger,
lightclient and
rjl493456442
as code owners
Member
Author
|
lgtm thanks! |
MariusVanDerWijden
previously approved these changes
Dec 19, 2025
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
LGTM, would like a second review on it though
jrhea
reviewed
Dec 21, 2025
core/blockchain_reader.go
Outdated
|
|
||
| // / SubscribeNewPayloadEvent registers a subscription for NewPayloadEvent. | ||
| func (bc *BlockChain) SubscribeNewPayloadEvent(ch chan<- NewPayloadEvent) event.Subscription { | ||
| return bc.newPayloadFeed.Subscribe(ch) |
Contributor
There was a problem hiding this comment.
I think SubscribeNewPayloadEvent should track subscriptions in bc.scope, like the other BlockChain.Subscribe* methods, so they’re cleaned up on shutdown.
Minor nit: there’s an extra / in the comment for SubscribeNewPayloadEvent.
Wrap SubscribeNewPayloadEvent with bc.scope.Track() to ensure subscriptions are properly cleaned up on shutdown, consistent with other BlockChain subscription methods. Also fix typo in the method's doc comment.
Savid
added a commit
to Savid/nethermind
that referenced
this pull request
Dec 23, 2025
Add NewPayloadEvent to track engine API newPayload block processing times and report them to ethstats. This enables monitoring of block processing performance. Related: ethereum/go-ethereum#33395
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add NewPayloadEvent to track engine API newPayload block processing times and report them to ethstats. This enables monitoring of block processing performance.
https://notes.ethereum.org/@savid/block-observability
related: #33231