Skip to content

perf: release RLock before blocking select in deliver #33446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hawkadrian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: release RLock before blocking select in deliver #33446

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions event/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,12 +206,24 @@ func (s *TypeMuxSubscription) deliver(event *TypeMuxEvent) {
if s.created.After(event.Time) {
return
}
// Otherwise deliver the event
// Copy postC under lock, then release lock before blocking select
s.postMu.RLock()
defer s.postMu.RUnlock()
postC := s.postC
s.postMu.RUnlock()

select {
case s.postC <- event:
case <-s.closing:
if postC == nil {
return
}

// Use recover to safely handle case where channel was closed
// between copying postC and entering select
func() {
defer func() {
recover() // Ignore panic from send on closed channel
}()
select {
case postC <- event:
case <-s.closing:
}
}()
}
Loading