Skip to content

core/vm: in selfdestruct gas calculation, return early if there isn't enough gas to cover cold account access costs #33450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwasinger wants to merge 2 commits into
base: master
Choose a base branch
from
Open

core/vm: in selfdestruct gas calculation, return early if there isn't enough gas to cover cold account access costs #33450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f96729
core/vm: in selfdestruct gas calculation, return early if there isn't…
jwasinger Dec 18, 2025
a0901c4
Update core/vm/operations_acl.go
jwasinger Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/vm/operations_acl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,10 @@ func makeSelfdestructGasFn(refundsEnabled bool) gasFunc {
// If the caller cannot afford the cost, this change will be rolled back
evm.StateDB.AddAddressToAccessList(address)
gas = params.ColdAccountAccessCostEIP2929

if contract.Gas < gas {
Copy link
Member

@rjl493456442 rjl493456442 Dec 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the EIP https://eips.ethereum.org/EIPS/eip-7928

BALs must include the Addresses accessed without state changes, including: Beneficiary addresses for SELFDESTRUCT

It means the beneficiary address should be tracked in the BALs regardless of the gas is sufficient should this opcode.
If we short circuit here and without executing if evm.StateDB.Empty(address) && evm.StateDB.GetBalance(contract.Address()).Sign() != 0 {
how should we explicitly track it?

return gas, nil
}
}
// if empty and transfers value
if evm.StateDB.Empty(address) && evm.StateDB.GetBalance(contract.Address()).Sign() != 0 {
Expand Down
Loading