ethclient: omit nil address/topics from filter args #33464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

madisoncarter1234 wants to merge 3 commits into ethereum:master from madisoncarter1234:fix/filter-arg-nil-address

+18 −3

madisoncarter1234 commented Dec 20, 2025

Fixes #33369

Summary

Only include address and topics fields in filter args when non-nil
Prevents "address": null from being sent in JSON-RPC payload
Fixes compatibility with strict JSON-RPC validators (e.g., Hedera)

Test

Added test case for nil addresses scenario.


          ethclient: omit nil address/topics from filter args

beb1dd6

Fixes ethereum#33369

madisoncarter1234 requested a review from fjl as a code owner

December 20, 2025 15:56

madisoncarter1234 added 2 commits

December 20, 2025 12:09


          ci: retrigger checks

a9571dc


          chore: retrigger CI

1264b8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet