Skip to content

Conversation

@iteyelmp
Copy link
Collaborator

Released a minor version to fix two high-priority bugs.
#11
#5

@qzhodl
Copy link

qzhodl commented Dec 25, 2025

What is your test plan and results?

@iteyelmp
Copy link
Collaborator Author

What is your test plan and results?

The wallet was successfully created on both the Mac and Linux servers, and operations such as locking, unlocking, and creating a repository were successfully performed.

A transaction was overwritten using "GOE_GAS_INC_PCT=150".

@qzhodl
Copy link

qzhodl commented Dec 25, 2025

What is your test plan and results?

The wallet was successfully created on both the Mac and Linux servers, and operations such as locking, unlocking, and creating a repository were successfully performed.

A transaction was overwritten using "GOE_GAS_INC_PCT=150".

I think we should run a full end-to-end test before cutting a major release, including but not limited:

  • All the steps covered on the readme
  • Vitalik blog uploading
  • CI test for the sdk
  • Mac / Linux / Wins coverage

@iteyelmp
Copy link
Collaborator Author

What is your test plan and results?

The wallet was successfully created on both the Mac and Linux servers, and operations such as locking, unlocking, and creating a repository were successfully performed.
A transaction was overwritten using "GOE_GAS_INC_PCT=150".

I think we should run a full end-to-end test before cutting a major release, including but not limited:

  • All the steps covered on the readme
  • Vitalik blog uploading
  • CI test for the sdk
  • Mac / Linux / Wins coverage

Should we upgrade ethstorage-sdk at the same time? This would be a good opportunity to test whether the SDK works on multiple platforms.

@qzhodl
Copy link

qzhodl commented Dec 25, 2025

What is your test plan and results?

The wallet was successfully created on both the Mac and Linux servers, and operations such as locking, unlocking, and creating a repository were successfully performed.
A transaction was overwritten using "GOE_GAS_INC_PCT=150".

I think we should run a full end-to-end test before cutting a major release, including but not limited:

  • All the steps covered on the readme
  • Vitalik blog uploading
  • CI test for the sdk
  • Mac / Linux / Wins coverage

Should we upgrade ethstorage-sdk at the same time? This would be a good opportunity to test whether the SDK works on multiple platforms.

New sdk change a lot from my point of view, so I think we can have a release for this version and upgrade SDK in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants