-
Notifications
You must be signed in to change notification settings - Fork 85
[ENG-2145] Add Policy conditional dependencies #7090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENG-2145] Add Policy conditional dependencies #7090
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
...des/api/alembic/migrations/versions/xx_2025_12_09_1236_6d5f70dd0ba5_add_policy_conditions.py
Outdated
Show resolved
Hide resolved
Greptile OverviewGreptile SummaryThis PR introduces policy conditional dependencies by creating a new Key Changes:
Implementation Quality:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, no comments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7090 +/- ##
==========================================
+ Coverage 87.31% 87.32% +0.01%
==========================================
Files 532 534 +2
Lines 34970 34999 +29
Branches 4048 4050 +2
==========================================
+ Hits 30533 30562 +29
Misses 3560 3560
Partials 877 877 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ticket ENG-2145
Description Of Changes
🎯 As a Privacy Admin, I want to create conditions that map request attributes to DSR policies, so that incoming privacy requests are automatically assigned the correct policy based on their characteristics.
Details
Policy conditions define when a specific DSR policy should be assigned to a privacy request. Each condition set is associated with a single policy and contains one or more rules that evaluate request data. Conditions can be simple (single field check) or complex (multiple fields with AND/OR logic).
This PR moves
policy.pyinto a policy dir and addssrc/fides/api/models/policy/conditional_dependency.pyalong with the alembic migration and tests. This follows the pattern established for both digest and manual tasks.Code Changes
src/fides/api/models/policy.pyinto new policy dirsrc/fides/api/models/policy/conditional_dependency.pySteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works