-
Notifications
You must be signed in to change notification settings - Fork 85
[ENG-2185] #7117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
JadeCara
wants to merge
10
commits into
ENG-2185-migration-remove-redundant-logging
from
ENG-2185-migration-dependency-model-simplification
Closed
[ENG-2185] #7117
JadeCara
wants to merge
10
commits into
ENG-2185-migration-remove-redundant-logging
from
ENG-2185-migration-dependency-model-simplification
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7117 +/- ##
==========================================
- Coverage 87.30% 87.26% -0.05%
==========================================
Files 533 533
Lines 35088 34977 -111
Branches 4067 4066 -1
==========================================
- Hits 30633 30522 -111
+ Misses 3570 3567 -3
- Partials 885 888 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…185-migration-dependency-model-simplification
JadeCara
commented
Dec 12, 2025
...embic/migrations/versions/xx_2025_12_12_1313_c37e8fde5a71_migrate_to_one_row_conditional_.py
Outdated
Show resolved
Hide resolved
JadeCara
commented
Dec 12, 2025
...embic/migrations/versions/xx_2025_12_12_1313_c37e8fde5a71_migrate_to_one_row_conditional_.py
Outdated
Show resolved
Hide resolved
…185-migration-dependency-model-simplification
Contributor
Author
|
Splitting changes into smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2185
Description Of Changes
This ticket is asking for consent manual tasks. We are going forward with a work around #7102 because consent task graphs and access/erasure task graphs are different and have different capabilities - especially around conditional dependencies.
In order to make conditional dependencies work for consent tasks and access/erasure tasks we need to be able to assign conditions to specific manual task instances/submissions rather than to the whole task. (There was another request to be able to assign users the same way).
In addition the original update model where conditions would be updated individually was replaced by a full delete replace on conditions making individual condition search/retrieval unnecessary. The logging being used by the front end is almost entirely the general audit logs so the manual task log table and utilities are now redundant.
This PR is the first step to getting manual tasks and conditions into shape for the above requirements. It is primarily clean up based on the first few rounds of customer use and learning actual usage patterns.
Code Changes
.fides/db_dataset.yml- update new column structuresrc/fides/api/alembic/migrations/versions/xx_2025_12_12_1313_c37e8fde5a71_migrate_to_one_row_conditional_.pyNew migration, does a data migration from multi row to single row structuresrc/fides/api/models/conditional_dependency/conditional_dependency_base.pyupdated to use new JsonB column removing old parent col etcsrc/fides/api/models/digest/conditional_dependencies.pyupdated to use new inherited basesrc/fides/api/models/manual_task/conditional_dependency.pyupdated to use new inherited basesrc/fides/api/task/manual/manual_task_conditional_evaluation.pyupdated to pull field addresses from tree rather than rowssrc/fides/api/task/manual/manual_task_utils.pyremoved the enum for the old row based conditional dependencies and added field address extraction function.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works