-
Notifications
You must be signed in to change notification settings - Fork 85
[ENG-2185] #7133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JadeCara
wants to merge
16
commits into
main
Choose a base branch
from
ENG-2185-add-new-jsob-tree-col
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[ENG-2185] #7133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7133 +/- ##
==========================================
- Coverage 87.22% 87.16% -0.06%
==========================================
Files 533 534 +1
Lines 35126 35315 +189
Branches 4082 4123 +41
==========================================
+ Hits 30639 30784 +145
- Misses 3597 3636 +39
- Partials 890 895 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JadeCara
commented
Dec 17, 2025
…des into ENG-2185-add-new-jsob-tree-col
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2185
Description Of Changes
This ticket was originally asking for consent manual tasks. We are going forward with a work around #7102 because consent task graphs and access/erasure task graphs are different and have different capabilities - especially around conditional dependencies.
There are going to be a few PRs cleaning up some un-used functionality or adjusting functionality for improved usage patterns. This PR adds a condition tree which will hold the full conditional dependency tree in a jsonb column on the "root condition." It also migrates current conditions to store their full tree on their root node. This will allow us to access the full tree without building it or having to build out all of the conditions each time. It is a clean up based on the first few rounds of customer use and learning actual usage patterns.
This PR:
Future PRs:
Code Changes
.fides/db_dataset.yml- removedManualTaskLogtablesrc/fides/api/alembic/migrations/versions/remove the manual task table.src/fides/api/db/base.py- removed ManualTaskLogsrc/fides/api/models/manual_task/manual_task.pyremoved the log class and updated the functions where manual task logs were created.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works