Skip to content

Conversation

@dsill-ethyca
Copy link
Contributor

Ticket []

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Dec 17, 2025 10:25pm
fides-privacy-center Ignored Ignored Dec 17, 2025 10:25pm

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 72.41379% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.33%. Comparing base (27068af) to head (3947952).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...onnection_configuration/connection_secrets_okta.py 40.42% 28 Missing ⚠️
src/fides/connectors/okta.py 28.57% 25 Missing ⚠️
src/fides/api/service/connectors/okta_connector.py 27.77% 13 Missing ⚠️
...c/fides/api/service/connectors/okta_http_client.py 98.52% 1 Missing and 1 partial ⚠️
src/fides/core/system.py 50.00% 2 Missing ⚠️
src/fides/api/api/v1/endpoints/validate.py 0.00% 1 Missing ⚠️
src/fides/cli/utils.py 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (72.41%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7150      +/-   ##
==========================================
+ Coverage   87.30%   87.33%   +0.03%     
==========================================
  Files         533      534       +1     
  Lines       35090    35281     +191     
  Branches     4067     4098      +31     
==========================================
+ Hits        30635    30814     +179     
- Misses       3570     3576       +6     
- Partials      885      891       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants