Open
Conversation
Change-Id: Id153bf3975a304047e574b57fd66399c227aaf04
Contributor
|
@trams Thank you for your many recent PRs! I merged a couple of them already, and will come back to the others after we get 1.1 released. |
Contributor
Author
|
@dossett thanks! I'll wait for 1.1 and then try to rebase |
Contributor
|
Hey @trams, thank you for all the contributions you've made! This is a great idea but I'm hesitant because it makes graphs of moderate or larger size look quite unwieldy. If you have thoughts on how to improve the UX on that, we'd love to hear them. |
Contributor
Author
|
Just out of curiosity what is the size of moderate graph? Most of our jobs contain around 3-5 steps and it look okayish (I didn't look for a proper picture for input|output) |
Contributor
|
@trams Many of our jobs are much larger than yours it sounds like -- a moderately-sized one would be around 10-15 steps for us(!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to show inputs and outputs in the flow diagram.
It is not very pretty. For one I didn't add any pictures for sources and sinks.
Also it contains a hack to filter __pipeX__pipeY outputs which may not work on your cluster
Apart from this it works perfectly and makes the diagram much more useful, especially for one step jobs.