Open
Conversation
jamesfe
force-pushed
the
sort_search_columns
branch
from
f9fd4b1 to
6ed78b3
Compare
Contributor
|
Hi @jamesfe, thanks for the contribution! It works perfectly. If you're interested, having the sorting capability in the other tables within Sahale, especially on the main page, would be great. Just for slightly better UX, the up/down arrows you mentioned would be awesome, and/or changing the cursor to indicate a clickable table field. |
Author
|
@nixsticks sure, I can do that - will probably push another commit this week. |
Contributor
|
Thank you, @jamesfe! We really appreciate the contribution. |
jamesfe
force-pushed
the
sort_search_columns
branch
from
6ed78b3 to
3953ea6
Compare
Author
|
A sample of the new functionality:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the waters with this PR - I use an off-the-shelf table sorter to add sorting ability to search results and if there is interest I can do it for the rest of the tables, maybe with the addition of little up/down arrows. Please let me know what you think!