Skip to content

Add filter preset functionality #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Alkorith wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add filter preset functionality #1277

Alkorith wants to merge 4 commits into from

Conversation

@Alkorith
Copy link

@Alkorith Alkorith commented Sep 12, 2023 •
edited
Loading

This is a feature patch to mostly resolve #1145. I'm not much a UI/UX guy so I don't know how to go beyond what I have done so far.

Rebirth Screenshots

Player pressed "Save"

2023-09-11-19_28_21

Player pressed "Export"

2023-09-11-19_28_55
2023-09-11-19_29_26

Til Death Screenshots

Player pressed "Save"

2023-09-11-19_30_57

Player pressed "Export"

2023-09-11-19_31_05
2023-09-11-19_31_13

Revisions

Rebase 1:

https://github.com/etternagame/etterna/compare/1a5e97b8d1fc137e3774d25d7fa95ba83acf26e4..9dae877d4b4f6ee9ff7295a3a43879967ebca459

@poco0317
Copy link
Member

poco0317 commented Mar 12, 2024 •
edited
Loading

save and export in this are rather redundant and should probably both go in the same folder - so we would eliminate one of those buttons.
i am interested in merging this, but i would prefer to know at least what we want the ui to look like even if it isnt coded yet

Alkorith added 4 commits April 1, 2025 22:06
@Alkorith
chore: Remove trailing whitespace and use unix line endings
6625f16
@Alkorith
chore(FilterManager): De-duplicate constants
246d14d
@Alkorith
feat(ThemeManager): Allow adding paths to lua package.path
3685684
@Alkorith
feat(filterpreset): Implement loading/saving filter presets
9dae877 
commit 3f6636a
Author: Alkorith <101947793+Alkorith@users.noreply.github.com>
Date:   Mon Sep 11 11:25:05 2023 -0500

    feat(filterpreset): Implement loading/saving filter presets

commit 9872554
Author: Alkorith <101947793+Alkorith@users.noreply.github.com>
Date:   Mon Sep 11 11:30:53 2023 -0500

    chore(filterpresets): Add lunajson dependency
@Alkorith
Copy link
Author

Alkorith commented Apr 2, 2025

save and export in this are rather redundant and should probably both go in the same folder - so we would eliminate one of those buttons.

I'd rather keep the ability to have a default preset loaded on startup so I can remove the export button in the next revision.

i am interested in merging this, but i would prefer to know at least what we want the ui to look like even if it isnt coded yet

Honestly, I thought just having the button as fine as is. I don't really know how else to improve the UI/UX. If you have any suggestions, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alkorith @poco0317